Fix grouped count aggregation on SQL Server#778
Open
apples-kksk wants to merge 1 commit into
Open
Conversation
apples-kksk
force-pushed
the
fix/sqlserver-groupby-removal-774
branch
from
ad70835 to
a18729b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested
Issue #774 reports that SQL Server compilation removes
GROUP BYfrom grouped count queries.Implemented
AsCount()aggregate queries.COUNT(*)query while keeping the innerGROUP BY.GroupBy(...).AsCount().Not covered
No changes to distinct aggregate behavior or unrelated compiler output.
Validated
dotnet test /home/molang/bounty-work/querybuilder/sqlkata.sln --filter CountWithGroupBydotnet build /home/molang/bounty-work/querybuilder/sqlkata.slngit diff --checkAlso ran full
dotnet test /home/molang/bounty-work/querybuilder/sqlkata.sln; non-MySQL tests passed, while 11MySqlExecutionTestcases failed because the local MySQL test service is not available in this environment.